Suggest associated method on deref types when path syntax method fails #100302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Aug 9, 2022
Comment on lines
+1658
to
+1681
| && pick.item.fn_has_self_parameter | ||
| && let Some(self_ty) = | ||
| self.tcx.fn_sig(pick.item.def_id).inputs().skip_binder().get(0) | ||
| && self_ty.is_ref() |
There was a problem hiding this comment.
This is a bit of a strange heuristic, but it works pretty well. Part of the issue here is that we don't have type information for the self arg (yet), since we haven't called check_expr.
This is a MaybeIncorrect suggestion, so I think it's fine for it to be a bit incorrect, as long as it's not suggesting something wildly wrong.
|
☔ The latest upstream changes (presumably #101225) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
deref-path-methods
branch
from
6dacc7d to
5f0431b
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
deref-path-methods
branch
2 times, most recently
from
d14a4f0 to
dfc8a00
Compare
This comment was marked as outdated.
This comment was marked as outdated.
compiler-errors
force-pushed
the
deref-path-methods
branch
from
dfc8a00 to
12a4952
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 4, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#100302 (Suggest associated method on deref types when path syntax method fails) - rust-lang#100647 ( Make trait bound not satisfied specify kind) - rust-lang#101349 (rustdoc: remove `.impl-items { flex-basis }` CSS, not in flex container) - rust-lang#101369 (Fix `global_asm` macro pretty printing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100278