Create chapter about rust-lang/rust issue triaging #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explains some of the existing processes around triage, and how I do it.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
fmease
approved these changes
Dec 24, 2023
|
I just saw #463 and one part I like there is the part about redirecting feature requests, I'll also add a note about that here. |
kpreid
reviewed
Dec 24, 2023
fmease
reviewed
Dec 25, 2023
jackh726
approved these changes
Dec 25, 2023
This was referenced Dec 26, 2023
|
I addressed the simple feedback and created an issue for the remaining questions. |
|
Realizing that technically maybe someone from t-release (or wg-triage) should merge (since that's where this chapter is) but I'm going to error on the side of "this is useful and reversible, and better to have than delay on technicalities" and merge. |
apiraino
reviewed
Dec 26, 2023
| It's okay if not all of these are always considered; treat it as a guideline, not a hard checklist. It is also not exhaustive. | ||
|
|
||
| - The issue should make sense, that is, it should present a problem. | ||
| - For example, if an issue is a question about Rust in general, the issue should be closed and the user redirected to URLO/Discord. |
There was a problem hiding this comment.
I'd probably explicitate the links (adding the references)
Suggested change
| - For example, if an issue is a question about Rust in general, the issue should be closed and the user redirected to URLO/Discord. | |
| - For example, if an issue is a question about Rust in general, the issue should be closed and the user redirected to [URLO] / [Discord] support forums. | |
| [URLO]: https://users.rust-lang.org | |
| [Discord]: https://discord.gg/rust-lang |
apiraino
reviewed
Dec 26, 2023
| - If the issue contains no reproduction but needs one, ask for one and add the `S-needs-repro` label | ||
| - The issue is the wrong place for some kinds of feature requests. Tell the author about it. | ||
| - Library API requests should follow [its processes](https://std-dev-guide.rust-lang.org/development/feature-lifecycle.html). | ||
| - Language changes should be redirected to [IRLO](https://internals.rust-lang.org/) or Zulip (t-lang). |
There was a problem hiding this comment.
Suggested change
| - Language changes should be redirected to [IRLO](https://internals.rust-lang.org/) or Zulip (t-lang). | |
| - Language changes should be redirected to [IRLO](https://internals.rust-lang.org/) or Zulip ([t-lang](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explains some of the existing processes around triage, and how I do it. If you have different opinions, please leave them here (though it would be nice for this not to drown in bikeshedding :3)
Some people that come to my mind here (that I remember being involved in discussions or that I see doing triage in the wild):
@saethlin @Enselic @kpreid @jackh726 @pnkfelix @apiraino @matthiaskrgr @aDotInTheVoid
some discussion:
https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Removing.20.60needs-triage.60
https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/needs-triage.20update
https://rust-lang.zulipchat.com/#narrow/stream/242269-t-release.2Ftriage/topic/E-needs-repro
https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Clarifying.20E-needs-mcve