Skip to content

Move conf.rs back into clippy_lints #6786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Feb 24, 2021

This is an alternative solution to #6785 to fix the CI break caused by #6756.

changelog: none

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 24, 2021
@flip1995
Copy link
Member

@bors r+

I'll approve this and hope that it fixes the deploy workflow. If not, I'll go and investigate further this evening.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

bors added a commit that referenced this pull request Feb 24, 2021
…=flip1995

Move conf.rs back into clippy_lints

This is an alternative solution to #6785 to fix the CI break caused by #6756.
@flip1995
Copy link
Member

cc @matthiaskrgr ^

@bors
Copy link
Contributor

bors commented Feb 24, 2021

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Feb 24, 2021

⌛ Testing commit 8047458 with merge 1f77068...

bors added a commit that referenced this pull request Feb 24, 2021
…=flip1995

Move conf.rs back into clippy_lints

This is an alternative solution to #6785 to fix the CI break caused by #6756.

changelog: none
@bors
Copy link
Contributor

bors commented Feb 24, 2021

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

Hm dogfood is failing on Mac 🤔

@smoelius
Copy link
Contributor Author

FWIW, the dogfood tests pass for me locally on a Mac.

Also, you probably noticed this, but it's failing with "signal: 9".

@flip1995
Copy link
Member

Didn't notice, Just skimmed the logs. So probably spurious.

Let's try again @bors retry

@bors
Copy link
Contributor

bors commented Feb 24, 2021

⌛ Testing commit 8047458 with merge 4545150...

@bors
Copy link
Contributor

bors commented Feb 24, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 4545150 to master...

@bors bors merged commit 4545150 into rust-lang:master Feb 24, 2021
@smoelius smoelius deleted the move-conf-rs-back-into-clippy-lints branch March 1, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants