Move constant write checks to temporary_assignment lint #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
force-pushed
the
move-constant-write-lint
branch
2 times, most recently
from
4169925 to
3fa0fc0
Compare
They make more sense here
KamilaBorowska
force-pushed
the
move-constant-write-lint
branch
from
3fa0fc0 to
815e434
Compare
phansch
added
the
S-waiting-on-review
flip1995
reviewed
Jan 4, 2019
flip1995
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit 815e434 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 4, 2019
Move constant write checks to temporary_assignment lint They make more sense here cc #3595
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They make more sense here
cc #3595