Skip to content

ui_test annotation cleanup #14232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

ui_test annotation cleanup #14232

merged 1 commit into from
Feb 16, 2025

Conversation

Alexendoo
Copy link
Member

Cleans up some changes from #11421

I searched for any .stderr files where the number of errors changed and reverted + manually added the annotations for them

Also fixes tests/ui/asm_syntax_not_x86.rs

r? @flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 16, 2025
flip1995
flip1995 approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking another look and fixing up those files! One ICE test needs its fixed file updated or a no-rustfix annotation. With that, feel free to merge.

@Alexendoo Alexendoo force-pushed the test-annotation-cleanup branch from e59ed29 to d03ae8b Compare February 16, 2025 16:53
@Alexendoo Alexendoo added this pull request to the merge queue Feb 16, 2025
Merged via the queue into rust-lang:master with commit 0f20a12 Feb 16, 2025
8 checks passed
@Alexendoo Alexendoo deleted the test-annotation-cleanup branch February 16, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexendoo @flip1995 @rustbot