Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch tests/compile-test.rs in cargo dev serve #13635

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Watch tests/compile-test.rs in cargo dev serve #13635

merged 1 commit into from
Nov 1, 2024

Conversation

Alexendoo
Copy link
Member

Changes to compile-test.rs will also need a rerun of collect-metadata

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2024
blyxyas
blyxyas approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Nov 1, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2024

📌 Commit a7aa8bf has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 1, 2024

⌛ Testing commit a7aa8bf with merge 9d03956...

@bors
Copy link
Contributor

bors commented Nov 1, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 9d03956 to master...

@bors bors merged commit 9d03956 into rust-lang:master Nov 1, 2024
8 checks passed
@Alexendoo Alexendoo deleted the cargo-dev-serve-watch-test branch November 2, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexendoo @rustbot @blyxyas @bors