missing_trait_methods: lint methods in definition order
#13159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Turning on hide whitespace makes the diff a lot easier to parse |
|
☔ The latest upstream changes (presumably #13144) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
force-pushed
the
missing-trait-methods-stable-order
branch
from
975b5bf to
10fb062
Compare
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lintcheck for #13157 showed a bunch of changes for
missing_trait_methodsThis is because
values_sortedwas sorting the entries by the key'sDefPathHash, this is stable for a given compiler but can change across versionschangelog: none