Skip to content

don't run clippy on dependencies when running cargo clippy #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2016
Merged

don't run clippy on dependencies when running cargo clippy #1069

merged 1 commit into from
Jul 4, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 4, 2016

fixes #1066

@mcarton
Copy link
Member

mcarton commented Jul 4, 2016

“oli-obk:lets_assume_dependencies_already_lint_clippy_for_themselves” 😄

@llogiq
Copy link
Contributor

llogiq commented Jul 4, 2016

LGTM. Good documentation wins, too.

@llogiq llogiq merged commit ecc75a8 into rust-lang:master Jul 4, 2016
@llogiq
Copy link
Contributor

llogiq commented Jul 4, 2016

We may want to add a command line flag for those who want to also lint all dependencies in the future.

@oli-obk oli-obk deleted the lets_assume_dependencies_already_lint_clippy_for_themselves branch July 4, 2016 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo-clippy unconditionally runs lints for path dependencies
3 participants
@oli-obk @mcarton @llogiq