Skip to content

ci/release: Ubuntu 20.04 being sunset #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

NickeZ
Copy link
Contributor

@NickeZ NickeZ commented Jun 7, 2025

Replace 20.04 with latest

runs-on: "ubuntu-20.04"
runs-on: "ubuntu-latest"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-latest is often a bad idea - you're kinda begging for CI to fail due to something that isn't your fault. D:

Could you please consider using 22.04 or 24.04 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah no problem, in this specific case using latest would've not broken though. As old versions will eventually be decommissioned.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true! Still, I think a PR every few years to update the version is just fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, fixed!

@NickeZ NickeZ force-pushed the nickez/ubuntu-20.04-sunset branch from 1c08ddd to da2a72d Compare June 7, 2025 18:58
Replace 20.04 with latest
@NickeZ NickeZ force-pushed the nickez/ubuntu-20.04-sunset branch from da2a72d to a346aff Compare June 7, 2025 18:59
@NickeZ NickeZ requested a review from onkoe June 7, 2025 19:09
Copy link

@onkoe onkoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I'm not a maintainer by the way - this PR just kinda caught my eye.

hope it gets merged soon! ;D

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

@emilio emilio added this pull request to the merge queue Jun 8, 2025
Merged via the queue into rust-lang:main with commit 058c8f2 Jun 8, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants