Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log item for which layout retrieval fails #2872

Conversation

mohe2015
Copy link
Contributor

Related #1768, ghpr-asia/wsdf#18

I think this would at least make analyzing this failure easier and based on the wsdf issue it seems that in some cases including another file also helps fixing this.

@mohe2015 mohe2015 force-pushed the unable-to-get-layout-information-log-item branch from 9029e60 to dcc3ebb Compare July 25, 2024 16:32
@mohe2015 mohe2015 force-pushed the unable-to-get-layout-information-log-item branch from dcc3ebb to c0b2470 Compare July 25, 2024 16:32
@aleb
Copy link

aleb commented Aug 13, 2024

Using unwrap_or_else leaves the impression that a value might be returned, but the block always panics. How about the change made in the ghpr-asia/wsdf#18 issue you linked:

let Some(layout) = layout else { panic... };

BTW, if anybody else is interested, the item is already logged at the very start of the method and the debug log can be enabled by setting the env var: RUST_LOG=debug

        debug!("<CompInfo as CodeGenerator>::codegen: item = {:?}", item);

@mohe2015 mohe2015 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants