Skip to content

Mentioned problem matchers and running cargo-watch as a VS Code Task #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2020
Merged

Mentioned problem matchers and running cargo-watch as a VS Code Task #5407

merged 4 commits into from
Jul 16, 2020

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan
Copy link
Contributor Author

@Lokathor, can you have a look at this and tell me if it explains the solution adequately?

@Lokathor
Copy link

Yes, excellent.

I'm not sure what the --package rust-analyzer part does. Do all user crates pass that flag regardless of their own crate name? I've never supplied the --package flag with cargo watch.

lnicola
lnicola reviewed Jul 16, 2020
View reviewed changes
lnicola
lnicola reviewed Jul 16, 2020
View reviewed changes
lnicola
lnicola reviewed Jul 16, 2020
View reviewed changes
@Lokathor Lokathor mentioned this pull request Jul 16, 2020
Closed
Michael-F-Bryan and others added 3 commits July 16, 2020 23:30
@Michael-F-Bryan @lnicola
Update docs/user/manual.adoc
9daa6b5 
Co-authored-by: Laurențiu Nicola <[email protected]>
@Michael-F-Bryan @lnicola
Update docs/user/manual.adoc
60a243b 
Co-authored-by: Laurențiu Nicola <[email protected]>
@Michael-F-Bryan @lnicola
Update docs/user/manual.adoc
5226e88 
Co-authored-by: Laurențiu Nicola <[email protected]>
@Michael-F-Bryan
Copy link
Contributor Author

I'm not sure what the --package rust-analyzer part does. Do all user crates pass that flag regardless of their own crate name?

Thanks for catching that @Lokathor. I believe it's the command matklad uses when working on rust-analyzer itself. The --package flag tells cargo you only want to build that particular package and its dependencies, not the entire workspace (which may contain extra tools or unrelated utility crates).

@matklad
Copy link
Member

matklad commented Jul 16, 2020

bors r+

Thanks Michael-F-Bryan, Lokathor and lnicola!

@bors
Copy link
Contributor

bors bot commented Jul 16, 2020

Build succeeded:

@bors bors bot merged commit 4759a39 into rust-lang:master Jul 16, 2020
@Michael-F-Bryan Michael-F-Bryan deleted the pattern-matcher-docs branch July 16, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Michael-F-Bryan @Lokathor @matklad @lnicola