refactor: migrate unmerge_use -> unmerge_imports to syntax editor
#19465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
snprajwal
force-pushed
the
unmerge-use-attrs
branch
4 times, most recently
from
3d57e5e to
1a6fe9f
Compare
Also ensures that attributes on the use item are applied to the new use item when unmerging. Signed-off-by: Prajwal S N <[email protected]>
snprajwal
force-pushed
the
unmerge-use-attrs
branch
from
1a6fe9f to
d368172
Compare
|
This is just me nitpicking, but would it make more sense to rename this assist to |
|
Those should have matching names for sure I agree |
Signed-off-by: Prajwal S N <[email protected]>
snprajwal
changed the title
unmerge_use to syntax editorunmerge_use -> unmerge_imports to syntax editor
snprajwal
changed the title
unmerge_use -> unmerge_imports to syntax editorunmerge_use -> unmerge_imports to syntax editor
|
Gentle ping on this and #19469 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensures that attributes on the use item are applied to the new use item when unmerging.
Fixes #19441, contributes to #18285, and supersedes #18565. This patch also includes some changes from #18484, specifically the addition of the
Removabletrait.cc @darichey, thanks for all the reviews on the other PR :) made things much easier for me