fix: auto-complete import for aliased function and module #18382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
dqkqd
commented
Oct 23, 2024
crates/ide-completion/src/render.rs
Outdated
| // Use the last segment when `item_to_import` matches `original_item`, | ||
| // as it will take the aliased name into account. | ||
| let local_name = if import_edit.item_to_import == import_edit.original_item { | ||
| import_edit.import_path.segments().last()?.clone() |
There was a problem hiding this comment.
I'm not sure if this is a right way to get the aliased name.
There was a problem hiding this comment.
It is a decent workaround for the core issue I mentioned for now I think, could put a FIXME comment mentioning #14079 as the proper fix for this above?
There was a problem hiding this comment.
I've added the FIXME.
There was a similar case with completion in pattern as well, so I added a testcase with the same fix.
|
So, the root issue is due to #14079, basically we should be treating imports as their own items to refer to. I'd need to look into that issue again to tell where we are with it (iirc only the IDE integration is missing, but that is still quite a bit to work on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #17042
Get the aliased name from
import_pathto use for import instead of name defined inside local module.