Skip to content

Use external stack in borrowck DFS #18255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Oct 6, 2024

Because damnit, it can crash r-a. Why do people make this stupid DFSes anyway (I get it, it's easier until it blows).

Fixes #18223 (who thought DFS will be the problem).

Because damnit, it can crash r-a. Why do people make this stupid DFSes anyway (I get it, it's easier until it blows).
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2024
@HKalbasi
Copy link
Member

HKalbasi commented Oct 6, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2024

📌 Commit 13f8534 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 6, 2024

⌛ Testing commit 13f8534 with merge 2b750da...

@bors
Copy link
Contributor

bors commented Oct 6, 2024

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 2b750da to master...

@bors bors merged commit 2b750da into rust-lang:master Oct 6, 2024
11 checks passed
@ChayimFriedman2 ChayimFriedman2 deleted the stack-overflow branch October 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust Analyzer Language Server crashes on big Rust files on VSCode.
4 participants