fix: When checking for forbidden expr kind matches, account for rawness #18153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An expression starting with `r#const` etc. should be accepted even in edition <=2021.
rustbot
added
the
S-waiting-on-review
|
Do we even need this check anymore at this point? I imagine this was done because our parser was not edition aware at the time |
|
I don't think the parser differentiates between those and other exprs when in macro (although it can be done probably). The entry point is just |
|
Right, the edition gating doesn't matter here my bad. |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An expression starting with
r#constetc. should be accepted even in edition <=2021.Fixes #18148.
This was not fixed when testing with edition 2024, I wonder whether that means our check for edition is incorrect...