Deunwrap add_missing_match_arms #15594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
DropDemBits
reviewed
Sep 12, 2023
| .map(|f| make::ext::simple_ident_pat(f.name().unwrap()).into()); | ||
| let pats = field_list.fields().map(|f| { | ||
| make::ext::simple_ident_pat( | ||
| f.name().expect("Record field must have a name"), |
There was a problem hiding this comment.
This feels like it could panic in the following situation, but I'm not exactly sure if it will:
enum A {
A,
Missing { a: u32, : u32, c: u32 }
}
fn a() {
let b = A::A;
match b$0 {}
}There was a problem hiding this comment.
Thank you for mentioning this, I checked it and it doesn't. Syntax tree for the missing field name shows :
[crates/ide-assists/src/handlers/add_missing_match_arms.rs:458] &f = RecordField {
syntax: [email protected]
[email protected]
[email protected] "u32"
,
how little the piece may be it is still being recognized as NAME and something like { a:32 , , c: u32} completely skips seeing a record field between a and c. So we are good.
There was a problem hiding this comment.
Would be good to add this as a test case though, we might change recovery in the future which could change this behavior.
Veykril
added
S-waiting-on-author
Although it doesn't panic now, further changes to how we recover from incomplete syntax may cause this assist to panic. To mitigate this a test case has been added.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last subtask of #15398