Skip to content

minor : Deunwrap convert_comment_block and desugar_doc_comment #15425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 22, 2023
Merged

minor : Deunwrap convert_comment_block and desugar_doc_comment #15425

merged 6 commits into from
Sep 22, 2023

Conversation

alibektas
Copy link
Member

Closes subtask 13 of #15398 . I still don't know a more idiomatic way for the for loops I added, any suggestion would make me happy.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2023
@lnicola
Copy link
Member

lnicola commented Aug 9, 2023

This makes the assist less lazy, so maybe it's better to put an expect in that function, or to ignore the prefix if it doesn't match.

r? @Veykril

@lnicola lnicola mentioned this pull request Aug 9, 2023
Closed
15 tasks
@alibektas
Copy link
Member Author

This makes the assist less lazy, so maybe it's better to put an expect in that function, or to ignore the prefix if it doesn't match.

r? @Veykril

I didn't understand this, so I am saving this for the next commit

@alibektas alibektas changed the title Deunwrap convert_comment_block Deunwrap convert_comment_block and desugar_doc_comment Aug 9, 2023
@alibektas alibektas changed the title Deunwrap convert_comment_block and desugar_doc_comment minor : Deunwrap convert_comment_block and desugar_doc_comment Aug 10, 2023
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2023
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2023
@alibektas alibektas force-pushed the deunwrap/convert_comment_block branch from da679e4 to 2fdf7e4 Compare September 10, 2023 21:15
@alibektas
Copy link
Member Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2023
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2023
@Veykril
Copy link
Member

Veykril commented Sep 22, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 22, 2023

📌 Commit 0a91a54 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 22, 2023

⌛ Testing commit 0a91a54 with merge 8139e8e...

@bors
Copy link
Contributor

bors commented Sep 22, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8139e8e to master...

@bors bors merged commit 8139e8e into rust-lang:master Sep 22, 2023
@alibektas alibektas deleted the deunwrap/convert_comment_block branch September 29, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

@Veykril Veykril Veykril left review comments

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alibektas @lnicola @Veykril @bors @rustbot