Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move manual to mdBook #15144

Closed
wants to merge 0 commits into from
Closed

Conversation

joshrotenberg
Copy link

@joshrotenberg joshrotenberg commented Jun 26, 2023

I made a mess of this last time around. Here is another try, fortunately with lots of hindsight.

Fixes #9504.

Manually deployed to: http://joshrotenberg.com/rust-analyzer/index.html

This is a work in progress. Here are the current steps, with probably more to come.

  • - Convert docs/user/manual.adoc to markdown.

I did this with pandoc using something similar to this blog post. For the static content,
this worked really well.

  • - Create a base mdbook setup.

I used mdbook init and then reused my previous book.toml and SUMMARY.md.

  • - Sweep through the generated markdown for lints, images, style, etc.

I moved each section according to the current manual to match the mdbook structure, and in the process fixed some minor issues, restructured headings, brought in the images, lint, etc.

  • - Move the developer guide to the book.

This isn't absolutely necessary but it does consolidate the docs in one place, and since docs/dev is already markdown it was easy. I did go through and do some minor linting/markdown style but for the most part the Contributing section of the book is the same as docs/dev.

  • - Convert generated docs from adoc to markdown.

This is a big chunk of the work, obviously, and is a fairly atomic step which makes everything above a little bit more difficult: the current manual and the new manual can't really coexist, at least not fully functional (or without some kind of interim conversion).

  • - Remove old docs.

Just a matter of deciding where the new manual should live (top level manual directory? docs/user? docs/manual?). I've got docs/manual for now.

Edit: had to change a path in a source file as well.

  • - Update release for mdbook files.

Right now the adoc files are handled explicitly in the task:

for adoc in [

  • - Figure out deployment.

I'm still a little confused about this, need to dig around again.

  • - Solve workflow failures.

  • - Deploy current state on fork.

See http://joshrotenberg.com/rust-analyzer/index.html. Will be updated periodically.

Screenshots

Introduction:

Screenshot 2023-06-26 at 4 43 03 PM

Features:

Screenshot 2023-06-28 at 12 03 38 PM

Assists:

Screenshot 2023-06-28 at 12 04 36 PM

Diagnostics:

Screenshot 2023-06-28 at 12 06 36 PM

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2023
@joshrotenberg joshrotenberg marked this pull request as ready for review June 28, 2023 20:12
@Veykril
Copy link
Member

Veykril commented Jul 6, 2023

This looks great!

@Veykril
Copy link
Member

Veykril commented Jul 13, 2023

oh before you continue to build on the merge commits, can you try and get rid of those. We don't really want to have merge commits aside from bors in the tree (Ill also be gone for the rest of the month so if you want a review from me in that time span you'll have to wait)

@joshrotenberg joshrotenberg force-pushed the mdbook branch 8 times, most recently from b6e72f6 to 00f4899 Compare July 14, 2023 16:46
@Veykril Veykril self-requested a review August 15, 2023 12:02
@Wilfred
Copy link
Contributor

Wilfred commented Aug 24, 2023

This looks really good! Anything I can do to help?

@joshrotenberg
Copy link
Author

This looks really good! Anything I can do to help?

I put it down for a bit since @Veykril was off, and then I messed something up with the commits and haven't had a chance to fix it yet. For the most part things were looking pretty good. Once I get it back in shape I guess making any updates to doc changes that have happened recently, and then reviews and decisions around the best way to merge and deploy this. If you have any feedback, though, I'm all ears.

@joshrotenberg
Copy link
Author

Once again I messed up my branch. Ugh. I'm going to move the work and information over and create a new one and hopefully get this thing taken care of.

@joshrotenberg
Copy link
Author

Hopefully this is the one! #15795

@Veykril @Wilfred would love a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual needs to be more helpful, friendly, and better organized
4 participants