Skip to content

Rename "unsized" coercion as "unsizing" #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WaffleLapkin
Copy link
Member

Built on top of #1731

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Apr 18, 2025
@WaffleLapkin WaffleLapkin force-pushed the unsize_coercion_rename branch from e3d2240 to 57d7980 Compare May 11, 2025 01:28
@traviscross traviscross added the P-lang-drag-4 Lang team prioritization drag level 4. label May 16, 2025
@traviscross
Copy link
Contributor

For whatever reason, "unsized coercion" feels more linguistically correct to me than "unsizing coercion". Here's one linguistic analog that perhaps underlies that feeling. We say "condo conversions" rather than "condoing conversions". The conversion makes the thing into a condo, so that's the kind of conversion that it is. Similarly, here, the coercion makes the thing unsized, so it's an unsized coercion.

@tshepang
Copy link
Member

tshepang commented May 29, 2025

heh, "the coercion makes the thing unsized" explanation tells me unsizing coercion sound closer to what is meant

unsized coercion sounds like a coercion that happens to an unsized type (or to a type that may or may not be sized)

@traviscross
Copy link
Contributor

traviscross commented May 29, 2025

Yes, I understand that as the motivation. I just can't find a lot of linguistic precedent for that reading in the context of converting things. E.g., "metric conversion" is to convert things to metric; it's a synonym for metrication. Similarly, if X is a religion, then an "X conversion" is a conversion to that religion. If I said we were doing an "octal conversion", I'd mean we were converting to octal. If we do a "prime factorization", it's the output rather than the input that is prime. Etc.

@tshepang
Copy link
Member

tshepang commented May 29, 2025

those other examples seems like they work due to convention, but they still feel not correct grammatically... they are ambiguous to those without context or experience

The old one was quite confusing and also incorrect in a few places.
@WaffleLapkin WaffleLapkin force-pushed the unsize_coercion_rename branch from 57d7980 to 451ec27 Compare June 1, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-lang-nominated P-lang-drag-4 Lang team prioritization drag level 4. S-waiting-on-review Status: The marked PR is awaiting review from a maintainer T-lang Team: Lang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants