Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic runtime and C-unwind documentation #1226
base: master
Are you sure you want to change the base?
panic runtime and C-unwind documentation #1226
Changes from all commits
eb818a7
f90fca6
915aa47
2f51185
a2efd56
abee069
5b28a23
5f78ce8
79db784
1151023
18d6ec9
92680b0
0bb3b0b
2e2f843
17f57cc
4c55570
9cfe94d
c7dbee8
2d2b9ee
fb2a8d8
14b4405
29df509
e9a8097
6b50173
cd4efeb
19dec5f
4d612a9
c655d7d
7022fa6
e0f870a
b712800
ccb6610
a78a1c9
c99233b
c057f76
db05b96
e43ab64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something this can link to that explicitly says what frames don't allow unwinding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall correctly, the intent here was to leave open the possibility of other future mechanisms prohibiting unwinding. It may also be that there's something else I'm not thinking of at the moment that can make unwinding past a frame illegal or undefined. But I believe that currently this example, i.e. a call that uses a non-unwinding ABI, is the only form of frame that doesn't allow unwinding. It would, at least, be appropriate to link to the
"c-unwind"
page from here, I think.