add some comments to clarify command-line argument munging in #482 #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Oct 17, 2018
src/bin/cargo-miri.rs
Outdated
| @@ -109,6 +110,8 @@ fn main() { | |||
| } | |||
| } | |||
| (true, "lib") => { | |||
| // For libraries we call `cargo rustc -- --test <rustc args>` | |||
| // Notice now that `--test` is a rustc arg rather than a cargo arg. | |||
There was a problem hiding this comment.
"libraries" here means "#[test] functions", right?
There was a problem hiding this comment.
Okay. Could you add that?
Took me a while to figure that out (originally, as in some months ago, I thought these are also just test binaries for cargo, I didn't know where the magic lived).
There was a problem hiding this comment.
Updated the comment.
apoelstra
force-pushed
the
2018-10-comment-482
branch
from
f2dd3e9 to
4fa5bfa
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #482 there was some question about what my argument-handling logic was doing. This adds comments to explain it.