Skip to content

Test windows random shims #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

Test windows random shims #3309

merged 1 commit into from
Feb 21, 2024

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Feb 21, 2024 •
edited
Loading

This adds tests for BCryptGenRandom and RtlGenRandom (aka SystemFunction036). Note that BCryptGenRandom comes in two flavours:

BCryptGenRandom(null_mut(), key.as_mut_ptr(), len, BCRYPT_USE_SYSTEM_PREFERRED_RNG)
BCryptGenRandom(BCRYPT_RNG_ALG_HANDLE, key.as_mut_ptr(), len, 0)

Fixes #3308

@RalfJung
Copy link
Member

Thanks. :)
@bors r+

@bors
Copy link
Contributor

bors commented Feb 21, 2024

📌 Commit db7fb0c has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 21, 2024

⌛ Testing commit db7fb0c with merge 65cc287...

@bors
Copy link
Contributor

bors commented Feb 21, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 65cc287 to master...

@bors bors merged commit 65cc287 into rust-lang:master Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add direct tests for the Windows RNG functions
3 participants
@ChrisDenton @RalfJung @bors