Update README for changes in x.py defaults #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rust-lang/rust#73964. The choices are either to link to `stage1` with rustup or build stage 2; this recommends to build stage2 to be consistent with the existing docs.
summarize/Readme.md
Outdated
| @@ -80,7 +80,7 @@ You can also profile your own custom build of rustc. First you'll have to clone | |||
|
|
|||
| ```bash | |||
| $ git clone https://github.com/rust-lang/rust.git | |||
| $ ./x.py build | |||
| $ ./x.py build --stage 2 | |||
| # This will take a while... | |||
| $ rustup toolchain link mytoolchain build/x86_64-unknown-linux-gnu/stage2 | |||
There was a problem hiding this comment.
Hm really stage1 should be enough; you should be comparing builds produced locally anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#73964.
The choices are either to link to
stage1with rustup or build stage 2; this recommends to build stage2 to be consistent with the existing docs.