Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-duplicate the search index #2425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nick1udwig
Copy link

Currently, the search index is duplicated in searchindex.js and searchindex.json. It seems the reason for the duplication is that the .json allows for async loading via fetch() and the .js provides a fallback in case CORS causes issues with the fetch().

The problem with having the duplicated index is that for large books, the index becomes quite large (2.5MB for my company's book!). It would be nice if the index didn't have to be duplicated.

This PR removes searchindex.json from the site output. It replicates the async functionality by reading in the searchindex.js file and parsing out the JSON within. The fallback remains unchanged.

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Aug 9, 2024
@SichangHe
Copy link

Related: #2403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants