Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makedev function signature on Apple targets #4377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nohajc
Copy link

@nohajc nohajc commented Apr 3, 2025

Description

Fix the makedev function signature according to actual implementation:
https://github.com/apple-oss-distributions/xnu/blob/8d741a5de7ff4191bf97d57b9f54c2f6d4a15585/bsd/sys/types.h#L154
https://developer.apple.com/documentation/kernel/1547212-makedev

Issue: #4360

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Apr 3, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

tgross35 commented Apr 3, 2025

This lgtm, but any reason not to also fix major and minor?

@nohajc
Copy link
Author

nohajc commented Apr 3, 2025

@tgross35 Oh, right. They're not even using dev_t there. Let me fix it. It's so bizarre...

@nohajc nohajc force-pushed the fix-apple-makedev branch from 8bf8de8 to 4159fb5 Compare April 3, 2025 22:10
@nohajc
Copy link
Author

nohajc commented Apr 3, 2025

Well, I just noticed the functions are only compiled for C++. C still uses those macros which are more loosely defined. Not sure that's reason enough to deviate from the type signatures even if they're questionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants