Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some identifiers for #4148 was missing, and this was not detected because
verify-build
does not rebuild whenRUST_LIBC_UNSTABLE_LINUX_TIME_BITS64=1 is set.
Fix the
verify-build
task by using a separatetarget-dir
and add the missing identifiersThis is probably not the best way of structuring the CI steps, it could also be set up using a matrix in the
verify-build
task ofci.yml
.Sources
https://github.com/torvalds/linux/blob/master/arch/mips/include/uapi/asm/socket.h#L125
https://github.com/torvalds/linux/blob/master/arch/powerpc/include/uapi/asm/socket.h
https://github.com/torvalds/linux/blob/master/tools/include/uapi/asm-generic/socket.h
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI