Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing SO_* values #4242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

snogge
Copy link
Contributor

@snogge snogge commented Jan 14, 2025

Some identifiers for #4148 was missing, and this was not detected because verify-build does not rebuild when
RUST_LIBC_UNSTABLE_LINUX_TIME_BITS64=1 is set.

Fix the verify-build task by using a separate target-dir and add the missing identifiers

This is probably not the best way of structuring the CI steps, it could also be set up using a matrix in the verify-build task of ci.yml.

Sources

https://github.com/torvalds/linux/blob/master/arch/mips/include/uapi/asm/socket.h#L125
https://github.com/torvalds/linux/blob/master/arch/powerpc/include/uapi/asm/socket.h
https://github.com/torvalds/linux/blob/master/tools/include/uapi/asm-generic/socket.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

A seperate target-dir is required for
RUST_LIBC_UNSTABLE_LINUX_TIME_BITS64.  It seems the build command does
not realize that things have to be rebuilt when
RUST_LIBC_UNSTABLE_LINUX_TIME_BITS64=1.

Increase timeout-minutes for verify build to 40, otherwise the nightly
build will time out.
The _NEW defines are not available in musl and ohos.
@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants