Haiku bsd #4221
Open
Haiku bsd #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haiku implements various parts of the (non-POSIX) BSD API. This moves it to a separate file, for easier future maintenance. No functional change intended; the changes are synchronized with R1Beta5
This includes: * sys/event.h: `kevent()`, `kqueue()`, data structure and constants * sys/iocomm.h: constants that are also defined for other platforms * stdlib.h: `mkstemps()` and `strtonum()` * sys/uov.h: `preadv()` and `pwritev()` * sys/wait.h: `wait4()`
tgross35
reviewed
Dec 31, 2024
Comment on lines
+3
to
+10
| // This file contains the BSD APIs available in Haiku. It corresponds to the | ||
| // header files in `headers/compatibility/bsd`. | ||
| // | ||
| // Note that Haiku's BSD compatibility is a combination of system APIs and | ||
| // utility libraries. There should only be system APIs in `libc`. When you are | ||
| // trying to determine whether something should be included in this file, the | ||
| // best indicator is whether it also exists in the BSD-specific definitions in | ||
| // this libc crate. |
There was a problem hiding this comment.
Would you mind turning this into //! module doc comments since it's moving anyway?
rustbot
added
the
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Haiku implements various parts of the (non-POSIX) BSD API. This moves it to a separate file, for easier future maintenance. It also adds some missing functionality that is part of other platforms and that may be useful for other crates.
Note that this synchronizes with Haiku R1 Beta 5, which is the latest relaase.
Sources
See https://github.com/haiku/haiku/tree/r1beta5/headers/compatibility/bsd/ for all the headers that match up with the ones in the
bsd.rsfile.Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
Note:
semveris not used by Haiku (yet), so N/A. The test currently fails, but in a panic! in the garando_syntax crate. The panic is the same before and after the changes.