-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Added timer_create and related calls #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @JohnTitor (rust_highfive has picked a reviewer for you, use r? to override) |
5f8019f
to
80a395e
Compare
Added: * timer_create * timer_getoverrun * timer_gettime * timer_settime * timer_delete
Closing and reopening to re-run CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is marked as WIP but no activities for about a month so leaving some reviews. I have a question about timer_t
but other structs/functions definitions look good to me.
@@ -13,6 +13,7 @@ pub type speed_t = ::c_uint; | |||
pub type nl_item = ::c_int; | |||
pub type id_t = i64; | |||
pub type vm_size_t = ::uintptr_t; | |||
pub type timer_t = *mut ::c_void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is timer_t
c_void
on DragonFlyBSD as well?
I only found this: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/85f00d18bcc1ab1d11df7193b597e70a43e0896d/sys/cpu/x86_64/include/stdint.h#L125
@@ -10,6 +10,7 @@ type __pthread_spin_t = __cpu_simple_lock_nv_t; | |||
pub type vm_size_t = ::uintptr_t; | |||
pub type lwpid_t = ::c_uint; | |||
pub type shmatt_t = ::c_uint; | |||
pub type timer_t = *mut ::c_void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, seems it's defined as int
, am I missing something?
@@ -4,6 +4,7 @@ pub type tcflag_t = ::c_uint; | |||
pub type clockid_t = ::c_int; | |||
pub type key_t = ::c_int; | |||
pub type id_t = ::c_uint; | |||
pub type timer_t = *mut ::c_void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems Android and Linux define __kernel_timer_t
as int
?
☔ The latest upstream changes (presumably #1961) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
Triage: I'm going to close this PR as inactive and some items are declared now, if there're still missing items and you find some time to work on it again, feel free to submit a new PR for it, thanks! |
Added:
https://www.freebsd.org/cgi/man.cgi?query=timer_create+&apropos=0&sektion=0&manpath=FreeBSD+9.0-RELEASE&arch=default&format=html
https://www.man7.org/linux/man-pages/man2/timer_create.2.html
https://man.netbsd.org/timer_create.2