Skip to content

Update dependencies #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dependencies #140

wants to merge 1 commit into from

Conversation

pczarn
Copy link

@pczarn pczarn commented Oct 21, 2019 •
edited
Loading

No description provided.

eddyb
eddyb reviewed Oct 23, 2019
View reviewed changes
Cargo.toml Outdated
grammer = "0.0.1"
proc-macro2 = "0.4.30"
proc-quote = "0.2.2"
grammer = "0.0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't publish grammer yet, note the [patch.'crates-io'] section at the bottom.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

eddyb
eddyb reviewed Oct 23, 2019
View reviewed changes
Cargo.toml
proc-macro2 = "0.4.30"
proc-quote = "0.2.2"
proc-macro2 = "1.0.6"
proc-quote = "0.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions are not compatible, you can see it in the Travis CI build log:

   Compiling proc-macro2 v0.4.30
   Compiling proc-macro2 v1.0.6

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why -- proc-quote 0.3 depends on proc-macro2 ^1.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you try to build this locally, Cargo.lock should tell you where the two versions come from.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, cargo tree -p proc-macro2 -i should show exactly where it comes from.

@eddyb
Copy link
Member

eddyb commented Mar 30, 2020

Oops, I forgot about this, just re-triggered checks, curious if the problem is gone now or if you have to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

@CAD97 CAD97 CAD97 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pczarn @eddyb @CAD97