Make CI successful #1407
Merged
Make CI successful #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows build fail until rust-lang#1396 is fixed.
With this change, the minimum required version will go up to nightly-2019-01-11.
This was referenced Jan 11, 2019
|
Thanks for the fix! Sorry for the delay-- I'll have a release out later today. |
Merged
|
@Thomasdezeeuw I left a couple comments-- I'd rather see the old one removed at the same time, or at least marked as deprecated and switch over our internal usage. I'd be happy to wait a bit if you have time now, otherwise I can do it myself-- whichever you'd prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow build fail on thumbv6m-none-eabi until Broken no_std build #1396 is fixed.
Related: This comment in Add new_count_waker #1402
Update to latest
Pin::set(Reborrow Pin<P> using &mut inPin::setrust#57419)With this change, the minimum required version will go up to
nightly-2019-01-11.
This PR covers #1406.
Fixes #1409