Skip to content

Refactor queries to use the more semantic postgres::Client methods #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor queries to use the more semantic postgres::Client methods #947

wants to merge 1 commit into from

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Aug 8, 2020

No description provided.

@Nemo157
Copy link
Member Author

Nemo157 commented Aug 8, 2020

(I'm sure touching almost every database query is unlikely to conflict with other merge requests 🤭)

@jyn514
Copy link
Member

jyn514 commented Aug 8, 2020

I'm really uncomfortable making changes like this without #874. The new code is definitely better - but are we sure all of it is tested? Changes like this have been a major source of outages in the past.

This is the same reason I don't want to refactor the builder too much until we have #822.

@Nemo157
Copy link
Member Author

Nemo157 commented Aug 11, 2020

(I'm planning to go through this and cherry-pick out all the changes that are covered in existing tests, just got distracted from finishing it on Sunday).

@Nemo157 Nemo157 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 11, 2020
@jyn514 jyn514 added C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-low Low priority issues labels Aug 21, 2020
@Nemo157
Copy link
Member Author

Nemo157 commented Oct 1, 2020

(superseded by moving to sqlx soon)

@Nemo157 Nemo157 closed this Oct 1, 2020
@Nemo157 Nemo157 deleted the update-queries branch March 8, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-low Low priority issues S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @jyn514