Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of licenses link in topbar #2740

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #2739.

It now looks like this:

Screenshot From 2025-02-20 13-46-15

cc @Manishearth

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner February 20, 2025 12:48
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Feb 20, 2025
@Manishearth
Copy link
Member

You may wish to remove the pure-menu-text styles if you don't need it anymore.

I somehow wasn't able to make it work with just pure-menu-link but it seems like you did.

@GuillaumeGomez
Copy link
Member Author

Nah I want to keep it to avoid having the text color changing when I hover the scale for example. Only when I hover the license links.

@syphar syphar merged commit 80bfc05 into rust-lang:master Feb 22, 2025
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Feb 22, 2025
@GuillaumeGomez GuillaumeGomez deleted the licenses branch February 22, 2025 10:23
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants