Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display crates not available on docs.rs in search results #2709

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

GuillaumeGomez
Copy link
Member

I'm frustrated in search sometimes, you can get empty results but still get "next page" links because it's actually not empty but just not available on docs.rs.

So instead of keeping this confusing situation, I preferred to make it more explicit:

image

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner January 6, 2025 16:18
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 6, 2025
@syphar
Copy link
Member

syphar commented Jan 6, 2025

@GuillaumeGomez do you have an example where this happend?

If I'm not missing anything right now I don't see any reason why crates shouldn't appear here.

So it can only happen temporarily until we synced it, orm until I run the consistency check?

@GuillaumeGomez
Copy link
Member Author

On docs.rs it can only happen if we blacklist crates. However when testing locally, it happens pretty much all the time.

@GuillaumeGomez
Copy link
Member Author

And fixed clippy too.

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the point of this, though it's mostly for local dev & other exceptional situations.

I manually tested & it seemed fine,

so the only thing missing would be a unit-test

@GuillaumeGomez
Copy link
Member Author

Sure, done!

@syphar syphar merged commit da1f235 into rust-lang:master Jan 11, 2025
9 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 11, 2025
@GuillaumeGomez GuillaumeGomez deleted the search-improvement branch January 11, 2025 19:57
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants