start queueing rebuilds for the latest version of each crate, if we had docs #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Oct 25, 2024
|
Thanks! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #464
Based on #2639 , will un-draft & rebase this PR when #2639 is merged.
This is an hourly job which continiously keeps a rebuild queue full to prevent having a too full queue, and with the idea in the future to continiously rebuild old docs.
The priority makes sure we're only using spare build capacity. A queue limit makes the queue manageable. For now I would like to define a max version to rebuild up to, we could think about setting this version depending on major rustdoc changes, or drop it at some point in favor of a flexible limit (like: rebuild everything older than X months).
So make the S3 bucket more manageable we might also either rebuild all releases, or run a re-package job that converts non-archive docs to archive ones.