-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move fontawesome icons check at compile-time #2616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like what's possible with rinja & rust with a deeper integration between rust & the template.
Generally:
- I think the compiled icon classes should be inside
font-awesome-as-a-crate
(perhaps behind a feature), and shouldn't have to be manually added. So all the icons can be added with the build script? - nit: I feel like accessing the icons in the templates shouldn't be via
filters::
but something likeicons::
3409ada
to
0cfee13
Compare
The icons structs are now generated in the sub-crate directly. Since there is no int into having the |
a11a032
to
3386e2b
Compare
3386e2b
to
2c59b68
Compare
2c59b68
to
be8e571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last question I think, thank you!
Generally I think before we create a release for the font-awesome crate we should add some documentation around the types (and for that matter, the old method to output the SVG). But we can do that separately.
be8e571
to
a061341
Compare
Updated! |
a061341
to
4c7764d
Compare
Removed |
Gonna send a follow-up for the doc for the fontawesome crate. |
Now, we have the list of icons we use with their "variant(s)" (ie Brands, Regular or Solid) represented by a trait. To render as one of the variant, the corresponding method needs to be called.