Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the "sort by" value switch to default value when use paginate #2352

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Fixed the "sort by" value switch to default value when use paginate #2352

merged 4 commits into from
Dec 6, 2023

Conversation

linyihai
Copy link
Contributor

@linyihai linyihai commented Dec 1, 2023

What this PR want to solve?

Fixed the issues #2350

This PR will retrive the sort value from base64encode "paginate"

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 1, 2023
@GuillaumeGomez GuillaumeGomez requested a review from syphar December 1, 2023 15:49
@linyihai linyihai marked this pull request as draft December 1, 2023 16:07
@linyihai linyihai marked this pull request as ready for review December 1, 2023 16:24
@linyihai linyihai requested a review from a team as a code owner December 1, 2023 16:24
syphar
syphar requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fix!

I had some comments, also I would love to see a test covering the new behavior.

src/web/releases.rs Outdated Show resolved Hide resolved
src/web/releases.rs Outdated Show resolved Hide resolved
@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 1, 2023
@linyihai
Copy link
Contributor Author

linyihai commented Dec 2, 2023

Thank you for working on the fix!

I had some comments, also I would love to see a test covering the new behavior.

Yes, I add a new testcase fot it.

@syphar syphar self-requested a review December 4, 2023 16:42
@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Dec 4, 2023
@syphar syphar merged commit ba417d3 into rust-lang:master Dec 6, 2023
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 6, 2023
@linyihai linyihai deleted the retrive-sort-by branch December 6, 2023 06:55
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linyihai @syphar @GuillaumeGomez