-
Notifications
You must be signed in to change notification settings - Fork 645
Upgrade to Ember v2.13 #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fbc42db
to
1699376
Compare
I noticed that the project still had a bunch of bower.json dependencies. I moved some of them, but was super conservative as I’d prefer to get these changes merged before continuing. Also updated some of the files and dependencies, like jshint->eslint, which included adding some TODOs to clean up afterwards. The package.json churn is because `ember init` now generates package.json with the same ordering as npm, to minimize churn.
Looks like this is failing the build |
yeah @locks there are a few eslint indentation things and then these errors on the ember tests?
|
Addressing it! |
This avoids PhantomJS keeling over because we used modern JavaScript APIs.
@carols10cents 👍 ? |
/* eslint-env node */ | ||
|
||
module.exports = { | ||
browsers: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carols10cents make sure this matches rust-lang/rfcs#1985
Merged this in before it gets too stale, and so we can do this all again next week when the next version of ember is out ;) Thank you for all your help @bjornharrtell and @locks!!! ❤️ |
Builds on the nice work by @bjornharrtell in #719 and adds some sprinkles.