publish: Move all features to feature2 if new syntax is used
#6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Seems reasonable to me.
This may change the error message users get when running cargo update in versions 1.19 to 1.51. There are different scenarios:
- The update selects a version with the new syntax, but did not need any of the features using the new syntax: Previously would get an error parsing the features.
- The update selects a version with the new syntax, and it needed a feature with the new syntax: Previously would get a
failed to select a version(after 1.26? saying it "does not have these features").
With this change, I think it will always be the second case.
|
☔ The latest upstream changes (presumably 8ca037e) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6135