trustpub: Change PUT /api/v1/trusted_publishing/tokens endpoint to POST
#11392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`POST` `PUT` should be used for updates, not for resource creation. The conventional HTTP method for resource creation in REST APIs is `POST`. This also matches what PyPI is using.
Turbo87
force-pushed
the
trustpub-exchange-method
branch
from
72dfbe2 to
b7847e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUTshould be used for updates, not for resource creation. The conventional HTTP method for resource creation in REST APIs isPOST. This also matches what PyPI is using.The endpoint is already used by the experimental GitHub Action, but since we control that and are aware of the change we can easily fix it on that side :)
Related:
PUT /api/v1/trusted_publishing/tokensAPI endpoint #11131PUT /api/v1/trusted_publishing/github_configsendpoint toPOST#11390