crate/delete: Add required reason input field #21747
Turbo87ci.yml
on: pull_request
Changed Files
18s
Backend / Lint
0s
Backend / cargo-deny
0s
Backend / Test
0s
Frontend / Lint
36s
Frontend / Test
2m 27s
Frontend / Test (playwright)
5m 34s
Annotations
10 errors, 1 warning, and 1 notice
|
[chromium] › acceptance/crate-deletion.spec.ts:4:7 › Acceptance | crate deletion › happy path @acceptance:
e2e/acceptance/crate-deletion.spec.ts#L31
1) [chromium] › acceptance/crate-deletion.spec.ts:4:7 › Acceptance | crate deletion › happy path @Acceptance
Error: Timed out 5000ms waiting for expect(locator).toHaveURL(expected)
Locator: locator(':root')
Expected string: "http://127.0.0.1:4200/"
Received string: "http://127.0.0.1:4200/crates/foo/delete"
Call log:
- expect.toHaveURL with timeout 5000ms
- waiting for locator(':root')
9 × locator resolved to <html lang="en" translate="no" class="notranslate" data-color-scheme="system">…</html>
- unexpected value "http://127.0.0.1:4200/crates/foo/delete"
29 |
30 | await page.click('[data-test-delete-button]');
> 31 | await expect(page).toHaveURL('/');
| ^
32 |
33 | let message = 'Crate foo has been successfully deleted.';
34 | await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(message);
at /home/runner/work/crates.io/crates.io/e2e/acceptance/crate-deletion.spec.ts:31:24
|
|
[chromium] › acceptance/crate-deletion.spec.ts:4:7 › Acceptance | crate deletion › happy path @acceptance:
e2e/acceptance/crate-deletion.spec.ts#L31
1) [chromium] › acceptance/crate-deletion.spec.ts:4:7 › Acceptance | crate deletion › happy path @Acceptance
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveURL(expected)
Locator: locator(':root')
Expected string: "http://127.0.0.1:4200/"
Received string: "http://127.0.0.1:4200/crates/foo/delete"
Call log:
- expect.toHaveURL with timeout 5000ms
- waiting for locator(':root')
9 × locator resolved to <html lang="en" translate="no" class="notranslate" data-color-scheme="system">…</html>
- unexpected value "http://127.0.0.1:4200/crates/foo/delete"
29 |
30 | await page.click('[data-test-delete-button]');
> 31 | await expect(page).toHaveURL('/');
| ^
32 |
33 | let message = 'Crate foo has been successfully deleted.';
34 | await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(message);
at /home/runner/work/crates.io/crates.io/e2e/acceptance/crate-deletion.spec.ts:31:24
|
|
[chromium] › acceptance/crate-deletion.spec.ts:4:7 › Acceptance | crate deletion › happy path @acceptance:
e2e/acceptance/crate-deletion.spec.ts#L31
1) [chromium] › acceptance/crate-deletion.spec.ts:4:7 › Acceptance | crate deletion › happy path @Acceptance
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveURL(expected)
Locator: locator(':root')
Expected string: "http://127.0.0.1:4200/"
Received string: "http://127.0.0.1:4200/crates/foo/delete"
Call log:
- expect.toHaveURL with timeout 5000ms
- waiting for locator(':root')
9 × locator resolved to <html lang="en" translate="no" class="notranslate" data-color-scheme="system">…</html>
- unexpected value "http://127.0.0.1:4200/crates/foo/delete"
29 |
30 | await page.click('[data-test-delete-button]');
> 31 | await expect(page).toHaveURL('/');
| ^
32 |
33 | let message = 'Crate foo has been successfully deleted.';
34 | await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(message);
at /home/runner/work/crates.io/crates.io/e2e/acceptance/crate-deletion.spec.ts:31:24
|
|
[chromium] › routes/crate/delete.spec.ts:45:7 › Route: crate.delete › happy path @routes:
e2e/routes/crate/delete.spec.ts#L58
2) [chromium] › routes/crate/delete.spec.ts:45:7 › Route: crate.delete › happy path @routes ──────
Error: Timed out 5000ms waiting for expect(locator).toHaveURL(expected)
Locator: locator(':root')
Expected string: "http://127.0.0.1:4200/"
Received string: "http://127.0.0.1:4200/crates/foo/delete"
Call log:
- expect.toHaveURL with timeout 5000ms
- waiting for locator(':root')
9 × locator resolved to <html lang="en" translate="no" class="notranslate" data-color-scheme="system">…</html>
- unexpected value "http://127.0.0.1:4200/crates/foo/delete"
56 | await page.click('[data-test-delete-button]');
57 |
> 58 | await expect(page).toHaveURL('/');
| ^
59 |
60 | let message = 'Crate foo has been successfully deleted.';
61 | await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(message);
at /home/runner/work/crates.io/crates.io/e2e/routes/crate/delete.spec.ts:58:24
|
|
[chromium] › routes/crate/delete.spec.ts:45:7 › Route: crate.delete › happy path @routes:
e2e/routes/crate/delete.spec.ts#L58
2) [chromium] › routes/crate/delete.spec.ts:45:7 › Route: crate.delete › happy path @routes ──────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveURL(expected)
Locator: locator(':root')
Expected string: "http://127.0.0.1:4200/"
Received string: "http://127.0.0.1:4200/crates/foo/delete"
Call log:
- expect.toHaveURL with timeout 5000ms
- waiting for locator(':root')
9 × locator resolved to <html lang="en" translate="no" class="notranslate" data-color-scheme="system">…</html>
- unexpected value "http://127.0.0.1:4200/crates/foo/delete"
56 | await page.click('[data-test-delete-button]');
57 |
> 58 | await expect(page).toHaveURL('/');
| ^
59 |
60 | let message = 'Crate foo has been successfully deleted.';
61 | await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(message);
at /home/runner/work/crates.io/crates.io/e2e/routes/crate/delete.spec.ts:58:24
|
|
[chromium] › routes/crate/delete.spec.ts:45:7 › Route: crate.delete › happy path @routes:
e2e/routes/crate/delete.spec.ts#L58
2) [chromium] › routes/crate/delete.spec.ts:45:7 › Route: crate.delete › happy path @routes ──────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveURL(expected)
Locator: locator(':root')
Expected string: "http://127.0.0.1:4200/"
Received string: "http://127.0.0.1:4200/crates/foo/delete"
Call log:
- expect.toHaveURL with timeout 5000ms
- waiting for locator(':root')
9 × locator resolved to <html lang="en" translate="no" class="notranslate" data-color-scheme="system">…</html>
- unexpected value "http://127.0.0.1:4200/crates/foo/delete"
56 | await page.click('[data-test-delete-button]');
57 |
> 58 | await expect(page).toHaveURL('/');
| ^
59 |
60 | let message = 'Crate foo has been successfully deleted.';
61 | await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(message);
at /home/runner/work/crates.io/crates.io/e2e/routes/crate/delete.spec.ts:58:24
|
|
[chromium] › routes/crate/delete.spec.ts:67:7 › Route: crate.delete › loading state @routes:
e2e/routes/crate/delete.spec.ts#L77
3) [chromium] › routes/crate/delete.spec.ts:67:7 › Route: crate.delete › loading state @routes ───
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
Locator: locator('[data-test-spinner]')
Expected: visible
Received: <element(s) not found>
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for locator('[data-test-spinner]')
75 | await page.click('[data-test-confirmation-checkbox]');
76 | await page.click('[data-test-delete-button]');
> 77 | await expect(page.locator('[data-test-spinner]')).toBeVisible();
| ^
78 | await expect(page.locator('[data-test-confirmation-checkbox]')).toBeDisabled();
79 | await expect(page.locator('[data-test-delete-button]')).toBeDisabled();
80 |
at /home/runner/work/crates.io/crates.io/e2e/routes/crate/delete.spec.ts:77:55
|
|
[chromium] › routes/crate/delete.spec.ts:67:7 › Route: crate.delete › loading state @routes:
e2e/routes/crate/delete.spec.ts#L77
3) [chromium] › routes/crate/delete.spec.ts:67:7 › Route: crate.delete › loading state @routes ───
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
Locator: locator('[data-test-spinner]')
Expected: visible
Received: <element(s) not found>
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for locator('[data-test-spinner]')
75 | await page.click('[data-test-confirmation-checkbox]');
76 | await page.click('[data-test-delete-button]');
> 77 | await expect(page.locator('[data-test-spinner]')).toBeVisible();
| ^
78 | await expect(page.locator('[data-test-confirmation-checkbox]')).toBeDisabled();
79 | await expect(page.locator('[data-test-delete-button]')).toBeDisabled();
80 |
at /home/runner/work/crates.io/crates.io/e2e/routes/crate/delete.spec.ts:77:55
|
|
[chromium] › routes/crate/delete.spec.ts:67:7 › Route: crate.delete › loading state @routes:
e2e/routes/crate/delete.spec.ts#L77
3) [chromium] › routes/crate/delete.spec.ts:67:7 › Route: crate.delete › loading state @routes ───
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
Locator: locator('[data-test-spinner]')
Expected: visible
Received: <element(s) not found>
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for locator('[data-test-spinner]')
75 | await page.click('[data-test-confirmation-checkbox]');
76 | await page.click('[data-test-delete-button]');
> 77 | await expect(page.locator('[data-test-spinner]')).toBeVisible();
| ^
78 | await expect(page.locator('[data-test-confirmation-checkbox]')).toBeDisabled();
79 | await expect(page.locator('[data-test-delete-button]')).toBeDisabled();
80 |
at /home/runner/work/crates.io/crates.io/e2e/routes/crate/delete.spec.ts:77:55
|
|
[chromium] › routes/crate/delete.spec.ts:85:7 › Route: crate.delete › error state @routes:
e2e/routes/crate/delete.spec.ts#L98
4) [chromium] › routes/crate/delete.spec.ts:85:7 › Route: crate.delete › error state @routes ─────
Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)
Locator: locator('[data-test-notification-message="error"]')
Expected string: "Failed to delete crate: only crates without reverse dependencies can be deleted after 72 hours"
Received: <element(s) not found>
Call log:
- expect.toHaveText with timeout 5000ms
- waiting for locator('[data-test-notification-message="error"]')
96 |
97 | let message = 'Failed to delete crate: only crates without reverse dependencies can be deleted after 72 hours';
> 98 | await expect(page.locator('[data-test-notification-message="error"]')).toHaveText(message);
| ^
99 | });
100 | });
101 |
at /home/runner/work/crates.io/crates.io/e2e/routes/crate/delete.spec.ts:98:76
|
|
Frontend / Percy Nonce
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
🎭 Playwright Run Summary
4 failed
[chromium] › acceptance/crate-deletion.spec.ts:4:7 › Acceptance | crate deletion › happy path @Acceptance
[chromium] › routes/crate/delete.spec.ts:45:7 › Route: crate.delete › happy path @routes ───────
[chromium] › routes/crate/delete.spec.ts:67:7 › Route: crate.delete › loading state @routes ────
[chromium] › routes/crate/delete.spec.ts:85:7 › Route: crate.delete › error state @routes ──────
2 skipped
194 passed (5.0m)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
playwright-report
|
8.35 MB |
|