Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak test/bench's help around filtering & libtest #5341

Merged
merged 1 commit into from
Apr 11, 2018
Merged

tweak test/bench's help around filtering & libtest #5341

merged 1 commit into from
Apr 11, 2018

Conversation

dwijnand
Copy link
Member

Attempt to bring more clarity about test/bench's filtering arg by
detailing the distinction and integration between cargo's test/bench and
libtest.

Also make sure to mention how to see libtest's help/usage message.

Fixes #5337

Feedback welcome. Also, how do I auto-generate the man pages in
src/etc/man/? I'm wasn't sure about the escaping to attempt manually
editing.

Attempt to bring more clarity about test/bench's filtering arg by
detailing the distinction and integration between cargo's test/bench and
libtest.

Also make sure to mention how to see libtest's help/usage message.

Fixes #5337
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Looks great to me, thanks!

I think we may be able to use clap nowadays to generate manpages, but I'm not sure

@bors
Copy link
Contributor

bors commented Apr 11, 2018

📌 Commit 3830904 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 11, 2018

⌛ Testing commit 3830904 with merge aafcf98...

bors added a commit that referenced this pull request Apr 11, 2018
tweak test/bench's help around filtering & libtest

Attempt to bring more clarity about test/bench's filtering arg by
detailing the distinction and integration between cargo's test/bench and
libtest.

Also make sure to mention how to see libtest's help/usage message.

Fixes #5337

Feedback welcome.  Also, how do I auto-generate the man pages in
src/etc/man/?  I'm wasn't sure about the escaping to attempt manually
editing.
@bors
Copy link
Contributor

bors commented Apr 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing aafcf98 to master...

@bors bors merged commit 3830904 into rust-lang:master Apr 11, 2018
@dwijnand dwijnand deleted the test-help branch April 11, 2018 15:53
@dwijnand
Copy link
Member Author

I think we may be able to use clap nowadays to generate manpages, but I'm not sure

looks like it's an open feature request: clap-rs/clap#552

@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tweak cargo test help message to not allude to multiple test running
5 participants