Skip to content

Do not suggest --name as a fix if its already used. #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

daschl
Copy link
Contributor

@daschl daschl commented Jan 9, 2018

This changeset partially fixes #4903 in that it doesn't suggest
using --name if its already being used (but the name is still
wrong).

This changeset partially fixes rust-lang#4903 in that it doesn't suggest
using --name if its already being used (but the name is still
wrong).
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 9, 2018

📌 Commit 7625cfa has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 9, 2018

⌛ Testing commit 7625cfa with merge 24aa3ca...

bors added a commit that referenced this pull request Jan 9, 2018
Do not suggest --name as a fix if its already used.

This changeset partially fixes #4903 in that it doesn't suggest
using --name if its already being used (but the name is still
wrong).
@bors
Copy link
Contributor

bors commented Jan 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 24aa3ca to master...

@bors bors merged commit 7625cfa into rust-lang:master Jan 9, 2018
@ehuss ehuss added this to the 1.25.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CLI parameter validation errors
5 participants