Defer bailing out workspace root probing #4816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit alters the logic to bail out on probing for `CARGO_HOME` to do it a little later rather than early on in the loop iteration, notably allowing members to reside in `CARGO_HOME` itself. Closes rust-lang#4815
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
bors r+ |
|
@bors r+ |
|
📌 Commit 4f28bc1 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 13, 2017
Defer bailing out workspace root probing This commit alters the logic to bail out on probing for `CARGO_HOME` to do it a little later rather than early on in the loop iteration, notably allowing members to reside in `CARGO_HOME` itself. Closes #4815
|
Wow, it's really hard to fix little corner cases without breaking someone else's code =/ |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit alters the logic to bail out on probing for
CARGO_HOMEtodo it a little later rather than early on in the loop iteration, notably
allowing members to reside in
CARGO_HOMEitself.Closes #4815