Skip to content

Gracefully handle errors in a lockfile #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2016
Merged

Conversation

matklad
Copy link
Member

@matklad matklad commented Aug 9, 2016

Closes #2715

Question: why internal errors are hidden by default? I think if the unexpected has happened you most likely want to know some details. See also #2756.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad matklad changed the title Gracefully handle duplicate package in a lockfile Gracefully handle errors in a lockfile Aug 9, 2016
@alexcrichton
Copy link
Member

@bors: r+ afae9f3

Thanks! Yeah Cargo's story with errors is a bit up in the air, but the idea is that "internal" errors are somewhat hidden by default as they're not useful, but we've come around to thinking we should actually never hide anything sometimes, so it's a tough balance...

Basically our thinking is that if the top of an error chain is internal, then that's massively bad and we throw out tons of contextual information. If the top is a "human error", though, we can print all those and ignore the internal ones by default (as the human ones describe it)

@bors
Copy link
Contributor

bors commented Aug 9, 2016

⌛ Testing commit afae9f3 with merge c205132...

bors added a commit that referenced this pull request Aug 9, 2016
Gracefully handle errors in a lockfile

Closes #2715

Question: why internal errors are hidden by default? I think if the unexpected has happened you most likely want to know some details. See also #2756.
@bors
Copy link
Contributor

bors commented Aug 9, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing c205132 to master...

@bors bors merged commit afae9f3 into rust-lang:master Aug 9, 2016
@matklad matklad deleted the opt-level branch August 19, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants