-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: do not validate submodules of fresh checkouts #14605
git: do not validate submodules of fresh checkouts #14605
Conversation
r? @weihanglo rustbot has assigned @weihanglo. Use |
We likely should update |
Could you update the commits to be how you want them reviewed and merged? For example, I could see this being
|
f847c14
to
f23e258
Compare
f23e258
to
e82ad5f
Compare
FYI ecb6398 was what I was asking for in splitting out a refactor commit. It makes it easier to follow what is intended with the actual performance fix. |
Fixes #14603
What does this PR try to resolve?
As is, we unconditionally validate freshness of the submodules of a checkout, even though we could assume that a fresh checkout has to have up-to-date submodules as well.
How should we test and review this PR?
N/A
Additional information
N/A