Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: do not validate submodules of fresh checkouts #14605

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

osiewicz
Copy link
Contributor

Fixes #14603

What does this PR try to resolve?

As is, we unconditionally validate freshness of the submodules of a checkout, even though we could assume that a fresh checkout has to have up-to-date submodules as well.

How should we test and review this PR?

N/A

Additional information

N/A

@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-git Area: anything dealing with git S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@epage
Copy link
Contributor

epage commented Sep 27, 2024

We likely should update _corrupted_checkout test to have a submodule to show that we recovery gracefully on interruption,

@epage
Copy link
Contributor

epage commented Oct 1, 2024

Could you update the commits to be how you want them reviewed and merged?

For example, I could see this being

  • Test commit
  • Refactor for checkout guard
  • Improve performance by adjusting the scope of the checkout guard

@osiewicz osiewicz force-pushed the do-not-check-submodule-freshness branch from f847c14 to f23e258 Compare November 11, 2024 03:50
@osiewicz osiewicz requested a review from epage November 11, 2024 04:16
@epage epage force-pushed the do-not-check-submodule-freshness branch from f23e258 to e82ad5f Compare November 11, 2024 22:33
@epage
Copy link
Contributor

epage commented Nov 11, 2024

FYI ecb6398 was what I was asking for in splitting out a refactor commit. It makes it easier to follow what is intended with the actual performance fix.

@epage epage added this pull request to the merge queue Nov 11, 2024
Merged via the queue into rust-lang:master with commit 31c96be Nov 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-git Area: anything dealing with git S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading of a git source is slow due to always checking if the submodule is updated
4 participants