Tweak how source paths are passed to the compiler #1164
Conversation
All paths printed will now be absolute paths unless the path is a descendant of the current directory. This should keep error messages and warnings of a reasonable length when working with the local project while still allowing errors in registry/git dependencies to be tracked down. Special care is taken in these situations to ensure that the error message from the compiler prints a reasonable path. Closes rust-lang#209 Closes rust-lang#694
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -289,3 +296,18 @@ fn filename(target: &Target) -> String { | |||
| }; | |||
| format!("{}{}-{}", flavor, kind, target.get_name()) | |||
| } | |||
|
|
|||
| // The dep-info files emitted by the compiler all have their listed paths | |||
There was a problem hiding this comment.
Eurgh. Shouldn't these be absolute?
There was a problem hiding this comment.
Possibly yeah, the source of the "problem" is that we call rustc src/foo.rs so the deps look like src/foo.rs and src/bar.rs instead of /path/to/src/foo.rs. I think that this mirrors gcc behavior, however. Either way, it's pretty easy to tweak in the future.
|
⌛ Testing commit 4a91d01 with merge c287aea... |
|
💔 Test failed - cargo-win-32 |
|
@bors: retry |
|
@bors: retr On Wed, Jan 14, 2015 at 12:55 AM, bors [email protected] wrote:
|
|
⌛ Testing commit 4a91d01 with merge ab16980... |
|
💔 Test failed - cargo-win-32 |
|
@bors: retry |
|
⌛ Testing commit 4a91d01 with merge 7452add... |
|
💔 Test failed - cargo-win-32 |
|
@bors: retry |
|
⌛ Testing commit 4a91d01 with merge 0e17305... |
|
💔 Test failed - cargo-win-64 |
|
@bors: retry |
All paths printed will now be absolute paths unless the path is a descendant of the current directory. This should keep error messages and warnings of a reasonable length when working with the local project while still allowing errors in registry/git dependencies to be tracked down. Special care is taken in these situations to ensure that the error message from the compiler prints a reasonable path. Closes #209 Closes #694
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
All paths printed will now be absolute paths unless the path is a descendant of
the current directory. This should keep error messages and warnings of a
reasonable length when working with the local project while still allowing
errors in registry/git dependencies to be tracked down.
Special care is taken in these situations to ensure that the error message from
the compiler prints a reasonable path.
Closes #209
Closes #694
Closes #1081