Add opacity to Ferris when hovering the code block #3755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Touchscreen better describes what we actually mean. This also aligns it with the note in ch04-02-references-and-borrowing ("You can hover your mouse over the circles (or tap on a touchscreen)...")
|
Thanks! I agree that this is an issue, but I am not sure this is the right solution for it—among other things, because it will still get in the way of selecting the code under it—for example, to copy it. I am going to close this, but we would be happy to think about other possible solutions over on #2893! Let's discuss there before trying to implement further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2893
This PR fixes an issue which can be experienced especially on mobile devices. In some cases Ferris overlays the code as it can be seen here:
This PR adds an opacity to Ferris as soon as the wrapper element (
<pre>) is hovered.On mobile the hover state is also given when the user taps an element. So if the user taps on the code, the container receives hover focus and Ferris becomes a little transparent. Then the user can see the code below.
When hovering Ferris itself (or clicking it on mobile) the transparency is removed and it becomes "solid" again.
If this PR will be accepted it would make sense to add a little notice explaining this behavior to the introduction chapter where Ferris is introduced.Edit: I added the note.