Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Blog Backend To Zola #573

Closed
wants to merge 1 commit into from
Closed

Conversation

XAMPPRocky
Copy link
Member

@XAMPPRocky XAMPPRocky commented Apr 21, 2020

Rendered

This switches the current bespoke blog backend for Zola. This should provide us access with more features to build and customise the blog without having to build all of those features outselves. There's still a few things needed to be done before this ready to merge, but the main structure should be ready for review. The two main commits are "Make Zola Templates" and "Initial Zola Config", the rest is moving files around, changing frontmatter syntax.

For contributors of the blog there is one major change which is that new blog urls are now generated at /<name>/ instead of /YYYY/MM/DD/<name>/ (Previous blog entries still work at on old URL). I made this trade off as it preserves the current two directory level structure we currently have. We could also perserve the /YYYY/MM/DD/<name>/ url formatting but change to a more nested directory layout.

To Do

  • Update CI
  • Fix CSS on Inside Rust page

r? @pietroalbini || @Manishearth

@Manishearth
Copy link
Member

I'm not sure if we should be changing the URL, even if it's done backwards compatibly. cc @steveklabnik ?

Have we diffed the output of the old and new website?

@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Apr 22, 2020

FWIW I'd also be okay with keeping at least some of current URL scheme. This was just the most compatible solution. The one problem I would see with keeping the current scheme is having to create a directory with date (2020/04/05/compiler-meetings.md). Though it could be said we should move away from the date in the filesystem and move it inside the file so that someone is less likely to merge with the wrong date (#567).

@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Apr 23, 2020

You should now be able to view the updated version at https://xampprocky.github.io/blog.rust-lang.org/ There's an inexplicable issue where the "Inside Rust" archive page has way more spacing than the main blog. I have to investigate it more.

@steveklabnik
Copy link
Member

Yes so, the custom backend here was because I needed to hit a deadline, I generally support moving it to something less bespoke.

I would prefer to not change URLs unless it's absolutely necessary. We have a lot of seo juice on the blog.

@Manishearth
Copy link
Member

Yeah, I think we should try to keep the URLs as is, such changes should not be made lightly

@XAMPPRocky
Copy link
Member Author

A change would be required to switch to Zola, since Zola doesn't currently doesn't support that kind of scheme without being inconvenient for contributors. While I do think this port merits changes in the URL scheme, I want to write more motivation for that change. In the mean time I've filed a feature request on Zola for adding the transformation to see if the problem resolves itself.

@XAMPPRocky
Copy link
Member Author

I'm going to close this PR for now, as I messed up the branch, and I want to write on the motivation before revisiting this PR.

@XAMPPRocky XAMPPRocky closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants