Recognize windows-sys signatures as "C" or "system" depending on cfg #677
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #676.
This is not an ideal solution because it relies on
--cfg=windows_raw_dylib
to be passed tobacktrace
if and only if the same flag is passed towindows-targets
. In Cargo this would always be the case and in Buck it's easy to arrange; not sure about different build systems.I did not come up with a way to write a check that succeeds if
super::windows_sys::$name
isunsafe extern "C" fn($($argty),*) -> $ret
ORunsafe extern "system" fn($($argty),*) -> $ret
and fails for all other signatures.