Update rust-toolchain to 1.70.0 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust version of AtCoder is 1.70.0.
qryxip
requested changes
Sep 23, 2023
There was a problem hiding this comment.
Could you update the verify job, too?
https://github.com/rust-lang-ja/ac-library-rs/actions/runs/6284180412/job/17066036094?pr=137
I think 1.71.1 is appropriate now.
|
I just remembered #118. Other platforms such as yukicoder still use <1.70.0. |
|
We must continue discussing what is the appropriate MSRV on #118 , and this issue might as well be closed for now. |
koba-e964
approved these changes
Oct 24, 2023
|
@qryxip |
|
I'm going to ignore tests that are not run and merge this PR, and then stop requiring 1.42.0-* tests to pass because they are stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust version of AtCoder is 1.70.0.